Distance table plugin, set maximum size of input before truncation from cmake #1077 #1236
Conversation
|
Wouldn't it be better to fetch the maximum from a command line option at run time, rather than set it at compile time? Ex: osrm-routed --max-table-size 1000 |
|
Maybe. It was my first intent, but not sure if a patch doing it would be accepted. So, I save my time and try the simplest way. |
|
then start by asking :-) |
|
I previously asked on IRC and here #544 |
|
as i'm not an official maintainer, i cannot tell you if it would be accepted. @DennisOSRM? |
|
I am a bit undecided here. The change is fairly easy, but I am not sure if this should be a compile-time parameter. |
|
Runtime parameter allow a more wide usage when osrm is packaged |
|
it seems tedious having to recompile just to change a setting |
|
Maybe the environment variable? |
|
@alex85k which is more evil as it circumvents the CMake build script 😀 |
|
I'm +1 on the command line option which a default value set to whatever you think is usable. The use case for this is that eventually this will get picked up by package managers for various distributions. This makes it much easier for users to use it output of the box. Many systems do not allow users to compile code on the server and some users don't know how to. Make it easy for the commodity user to install, configure and go. Developers and hackers can always compile and tweak code to fit their needs. |
|
+1 on the command line option with a default value! |
|
@frodrigo do you want to run point on reworking this PR into a command line option with a default value? |
|
Yes. I will look at. |
|
any updates, @frodrigo? |
|
Still in my todo list, but a bit busy now. |
|
This gets implemented in #1298, right? Can we close here? |
Distance table plugin, set maximum size of input before truncation from cmake #1077