Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces and/not with &&/! for windows #1871

Merged
merged 4 commits into from
Jan 9, 2016
Merged

Conversation

MoKob
Copy link

@MoKob MoKob commented Jan 8, 2016

just as the title says...

@daniel-j-h
Copy link
Member

Interesting. Does Windows not support these?
http://en.cppreference.com/w/cpp/language/operator_alternative

@MoKob
Copy link
Author

MoKob commented Jan 8, 2016

Well. According to all the failing AppVeyor builds, it strongly looks like it. At least Visual Studio does not support them, as far as I remember from my personal experience.

@danpat
Copy link
Member

danpat commented Jan 9, 2016

According to this:

http://stackoverflow.com/a/6006540

Visual C++ will support them when it's in "standards compliance" mode, enabled by adding /Za to the command line.

Looks like we're building under /Ze by default, we might want to switch to /Za:

https://msdn.microsoft.com/en-us/library/34h23df8.aspx#Anchor_9

@TheMarex TheMarex force-pushed the guidance-windows-fix branch from 7af06e1 to 23cd4d5 Compare January 9, 2016 18:42
@TheMarex TheMarex merged commit 23cd4d5 into develop Jan 9, 2016
@MoKob MoKob deleted the guidance-windows-fix branch January 12, 2016 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants