Rips out dead code from the container.hpp and creates for_each_pair.hpp #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added two TODOs that I would like to address in the future.
TheMarex
force-pushed
the
refactor_container_code
branch
from
b8e586b to
c93ca02
Compare
| { | ||
| function(*begin, *next); | ||
| begin = std::next(begin); | ||
| next = std::next(next); |
There was a problem hiding this comment.
just nit-pitting, but I've read somewhere that it would be best to bring these kind of functions into the namespace (using std::next) so that the compiler can decide which next to use, if there should be some better fitting one.
Just as you've done below for begin and end.
There was a problem hiding this comment.
Hmm for begin / end I can understand the need for Koenig lookup (so that it e.g. works on raw arrays); next should eventually dispatch to operator++ (for forward iterators), and that the iterator concept guarantees for and lets the user implement it in any way she wishes.
|
Changes Unknown when pulling c93ca02 on refactor_container_code into ** on develop**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: after merging #1660 is resolved; close the issue.
I manually checked all the occurrences in the code base (phew..); where it is placed but an exception might get thrown, we might as well take the
std::terminatethat comes with it (e.g. in not being able to log). I also added two TODOs that I would like to address in the future.