The Big Cleanup II

[daniel-j-h]

wip

[MoKob]

I deem these common header guard names dangerous if they do not at least include some directory/other identifier. Good chance of header guard conflicts.

[daniel-j-h]

Yes you are right. Will revert to the osrm prefix again. 👍

[TheMarex]

@daniel-j-h can we maybe keep the TODO list in this PR? I'm currently trying to split some smaller items out for @karenzshea to learn about C++ compiler errors 😸

[daniel-j-h]

@TheMarex sure! @karenzshea hit me up if you need help in fighting compilers 🔪

[daniel-j-h]

• RouteParameter should not depend on boost spirit
• RouteParameter should either be a struct or have getter-setter, not both <- is done this way to act as a Spirit handler, setters are Spirit callbacks
• Drop the weak coupling of plugins over service name + registration
  -> libosrm interface should be typed like node-osrm
• Rename external_memory_node.hpp
• FixedPointNumber is not used anywhere
• Remove node_id.hpp
• Remove check-hsgr
• FIXME xor_fast_has_shorage.hpp only has space for 2^16 nodes
• coordinate_calculation should be a namespace not struct
• Remove reference to crc32_processor.hpp from extractor.hpp
• Make douglas_peuker a function
• Make PolylineCompressor a function
• Make PolylineFormatter a function
• Make RouteNameExtraction a function
• Remove SearchEngineData, fold into SearchEngine
• Drop gpx support
• Make TravelMode an enum class not possible, would increase node sizes b/c enum classes are not bit-packable
• Rename TurnInstrauctionsClass -> should be a function
• rename OSRM class -> Engine
• ComputeAngle should be a free function and in coordinate_calculation
• unlint util/:
  • floating_point.hpp is it used?
  • interger_range.hpp is it used?
  • create json/ subfolder
• mercator should be a namespace in coordinate_calculation
• rename osrm_exception.hpp to exception.hpp
• check if range_algorithms is used somewhere
• remove tribool and fold into server code
• remove xml renderer
• remove typedefs.hpp -> No global NodeIDs and EdgeIDs !!!
• replace SimpleLogger with RTD_LOG
• Move debug_geometry to extractor
• routing_algorithms -> routing
• use sort_unique_resite or remove
• move matching_debug_info to engine/map_matching
• hash implementation in processing_chain should use util/std_hash
• replace DistTableWrapper with more generic implementation (2d vector wrapper or something)
• move TarjanSCC from extractor to util
• Remove DescriptorTable
• Rename FixedPointCoordinate -> Coordinate
• extraction_helper_functions does not follow style guide, should be cpp file
• lua_function_exists needs to be renamed
• NodeBasedDynamicGraphFromEdges needs to be renamed
• read_file_lower_content needs to be renamed
• abstract routed_options and fold into tools/routed.cpp
• rename geometry_string test to polyline
• move duration_parsing to extractor
• remove the config file option for osrm-extract and osrm-prepare
• change extractor class name to Extractor
• HilbertCode should be function
• polyline_compressor.cpp:33 "left shift of negative value -106", UB: found with -fsanitize=undefined
• EncodeToBase64 / DecodeFromBase64 refactor, by value, cleanup

[emiltin]

refactor lua profiles, with base class/functions containing code that's reused between profiles?

[daniel-j-h]

@emiltin I would love if you could tackle that. The profiles desperately need some refactoring and small fixes like for this ticket: #1567.

[TheMarex]

@daniel-j-h can you please rebase + merge this as we shifted to API work?

[daniel-j-h]

Okay. Ticketing remaining issues up in #1971.

Waiting for Travis, then will merge.

[daniel-j-h]

Hopefully this should fix Travis. Waiting for ok, then will merge.