Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highway=motorway_link does not imply oneway, fixes #1662 #2491

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

@daniel-j-h daniel-j-h force-pushed the motorway-link-does-not-imply-oneway branch from f3125f3 to 92337b8 Compare May 31, 2016 16:06
| waypoints | route | turns |
| a,e | abcde,abcde | depart,arrive |
| f,e | fgc,abcde,abcde | depart,merge slight left,arrive |
| a,i | abcde,chi,chi | depart,on ramp slight right,arrive |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a -> i should always have been on ramp and not off ramp, or am I missing something here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are exiting the motorway abcde at this point. So chi is an off ramp (its not about getting on / off the ramp but whether you are leaving / entering a motorway)

@daniel-j-h daniel-j-h force-pushed the motorway-link-does-not-imply-oneway branch from 92337b8 to de85bec Compare June 1, 2016 08:49
@daniel-j-h
Copy link
Member Author

Fixed the on/off ramp test cases relying on implied oneway.

@TheMarex
Copy link
Member

TheMarex commented Jun 1, 2016

This will probably degrade the routing performance initially.

@planemad keep a look out to routing bugs that would occur here after the next OSRM release. Do you think we could add the non-tagged motorway_link roads to to-fix?

@planemad
Copy link

planemad commented Jun 1, 2016

@TheMarex unless this causes routing failures, it might be hard to keep a track of routing bugs unless explicitly reported. In the meanwhile, we can detect such ways and load into to-fix for a community review.

@daniel-j-h daniel-j-h force-pushed the motorway-link-does-not-imply-oneway branch from de85bec to c6dd13b Compare June 1, 2016 18:18
@daniel-j-h daniel-j-h force-pushed the motorway-link-does-not-imply-oneway branch from c6dd13b to c490752 Compare June 2, 2016 11:06
@daniel-j-h daniel-j-h merged commit c490752 into master Jun 2, 2016
@MoKob MoKob deleted the motorway-link-does-not-imply-oneway branch June 15, 2016 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants