-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highway=motorway_link does not imply oneway, fixes #1662 #2491
Conversation
f3125f3
to
92337b8
Compare
| waypoints | route | turns | | ||
| a,e | abcde,abcde | depart,arrive | | ||
| f,e | fgc,abcde,abcde | depart,merge slight left,arrive | | ||
| a,i | abcde,chi,chi | depart,on ramp slight right,arrive | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a -> i should always have been on ramp and not off ramp, or am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are exiting the motorway abcde at this point. So chi is an off ramp (its not about getting on / off the ramp but whether you are leaving / entering a motorway)
92337b8
to
de85bec
Compare
Fixed the on/off ramp test cases relying on implied oneway. |
This will probably degrade the routing performance initially. @planemad keep a look out to routing bugs that would occur here after the next OSRM release. Do you think we could add the non-tagged |
@TheMarex unless this causes routing failures, it might be hard to keep a track of routing bugs unless explicitly reported. In the meanwhile, we can detect such ways and load into to-fix for a community review. |
de85bec
to
c6dd13b
Compare
c6dd13b
to
c490752
Compare
For #1662.
References: