Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[not ready] Left hand driving #2670

Closed
wants to merge 4 commits into from
Closed

[not ready] Left hand driving #2670

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6987e3
Initial left hand driving implementation
Jul 18, 2016
438b179
commit test file
Jul 19, 2016
b8b4165
addressed comments
oxidase Jul 19, 2016
0dbf2bc
added a lanes test in clockwise roundabouts
oxidase Jul 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions features/guidance/anticipate-lanes.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,38 @@ Feature: Turn Lane Guidance
| waypoints | route | turns | lanes |
| a,h | ab,gh,gh | depart,roundabout-exit-5,arrive | ,slight right:false slight right:true, |

@anticipate @todo
Scenario: Anticipate with lanes in roundabout where we stay on the roundabout for multiple exits
# Scenario requires correct lane handling for clockwise roundabouts
Given the profile "lhs"
And the node map
| | | a | | |
| | | b | | |
| h | c | | g | |
| | | | | |
| | d | | f | |
| | | e | | |
| x | | | | y |

And the ways
| nodes | turn:lanes:forward | highway | junction |
| ab | slight_left\|slight_left | primary | |
| bg | | primary | roundabout |
| gf | | primary | roundabout |
| fe | | primary | roundabout |
| ed | | primary | roundabout |
| dc | slight_left | primary | roundabout |
| cb | | primary | roundabout |
| ch | | primary | |
| ex | | primary | |
| dx | | primary | |
| gy | | primary | |
| fy | | primary | |

When I route I should get
| waypoints | route | turns | lanes |
| a,h | ab,ch,ch | depart,roundabout-exit-5,arrive | ,slight right:false slight right:true, |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to change the expected lanes output here from slight right to slight left.
If you take a look at the way ab and dc above, they only have slight left lanes.

Counterclockwise vs clockwise does not change the turn lane's direction.
It only changes lane anticipation's behavior in keeping the user to the left/right.

Copy link
Contributor

@oxidase oxidase Jul 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, here must be slight left, but the test fails because query returns an empty result, so i set todo state and kept the original expecation, because had no idea what should be be the expected result.

I will try to find out the reason during the next week. @MoKob showed me the starting place https://github.com/Project-OSRM/osrm-backend/blob/master/src/extractor/guidance/turn_lane_matcher.cpp#L54-L103


@anticipate
Scenario: Departing or arriving inside a roundabout does not yet anticipate lanes
Given the node map
Expand Down