Disable conditional restriction handling by default in configs #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rebase after we merge #4623 |
TheMarex
requested changes
Oct 19, 2017
| storage::io::FileWriter writer(conditional_penalties_filename, | ||
| storage::io::FileWriter::GenerateFingerprint); | ||
| extractor::serialization::write(writer, indexed_conditionals); | ||
| if (!indexed_conditionals.empty()) |
There was a problem hiding this comment.
The reason why we write out en empty file here is that otherwise the loading code will fail: https://travis-ci.org/Project-OSRM/osrm-backend/jobs/289928057#L2508
The .restrictions file can be empty but is not optional.
include/updater/updater_config.hpp
Outdated
| ".osrm.geometry", | ||
| ".osrm.fileIndex", | ||
| ".osrm.properties"}, | ||
| {".osrm.restrictions"}, |
There was a problem hiding this comment.
.restrictions is actually not optional, but can be empty.
|
From reading the ticket / conversation here it looks like this is a bug fix which should go into master and a release asap? What needs to be done here? |
karenzshea
force-pushed
the
conditionals/disable
branch
2 times, most recently
from
5dfb1cb to
a5597c6
Compare
… parsing by default
karenzshea
force-pushed
the
conditionals/disable
branch
from
a5597c6 to
78fb519
Compare
TheMarex
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #4620
Tasklist