Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop signs for the turn function in lua profiles #4828

Closed
wants to merge 3 commits into from

Conversation

chaupow
Copy link
Member

@chaupow chaupow commented Jan 24, 2018

Issue

Implementing #2652

Tasklist

@chaupow chaupow self-assigned this Jan 24, 2018
@chaupow chaupow modified the milestone: 5.16.0 Feb 5, 2018
@SiarheiFedartsou
Copy link
Member

@mjjbell what do you think about it? Should we finish it?

@mjjbell
Copy link
Member

mjjbell commented Sep 22, 2022

Yes I think it's worth doing.

I remember reading this when implementing the traffic signal directions in #6153
It seems similar in that you need to know in the direction of approach to the node, so if this PR it too out-of-date, we could try and reuse that to implement it.

@mjjbell
Copy link
Member

mjjbell commented Sep 22, 2022

These changes look very similar to what I did for traffic signals, but they didn't make it to master: d1b9dff

@SiarheiFedartsou
Copy link
Member

Yes I think it's worth doing.

We should probably decide what to do with #6354 then - I would expect quite a lot of merge conflicts if do this in current code base and then try to merge #6354

@mjjbell
Copy link
Member

mjjbell commented Sep 25, 2022

Ok, I'll take a look soon.

@DennisOSRM
Copy link
Collaborator

closing stale PR. Reopen if still relevant.

@DennisOSRM DennisOSRM closed this May 10, 2024
@DennisOSRM DennisOSRM deleted the feature/stops_in_turns branch May 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants