Remove deduplication of unpacked_path_segments in MM collapsing #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenzshea
changed the title
|
Also, thanks to @danpat for teasing out a good test case expressing the bug |
karenzshea
force-pushed
the
fix/undedupe
branch
from
118bbe0 to
b9e83c1
Compare
danpat
approved these changes
Feb 24, 2018
danpat
pushed a commit
that referenced
this pull request
Feb 24, 2018
danpat
pushed a commit
that referenced
this pull request
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes the issue in indicated by #4909
Bug
Leg collapsing for some traces with high sample rates, resulted in dropped geometries like shown by the red line in the image above, particularly around corners.
Root cause
The bug was caused by a mishandling of
unpacked_path_segmentscollapsing. The scenario arose when two points in a trace were located on the same edge, resulting in a 0 length segment, which, because the leg collapsing was incorrectly removing the lastunpacked_path_segmentvalue from the previously last collapsed segment, would sometimes result in missing coordinates in the end result.Tasklist
Requirements / Relations
5.16 cc @chaupow