Use smaller range for U-turn angles in map-matching #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any idea why? Is the uturn detection still triggered? |
karenzshea
force-pushed
the
adjust-uturn-range
branch
from
802279e
to
0fc8f67
Compare
karenzshea
approved these changes
Feb 28, 2018
oxidase
force-pushed
the
adjust-uturn-range
branch
from
0fc8f67
to
d65a2a4
Compare
oxidase
force-pushed
the
adjust-uturn-range
branch
from
d65a2a4
to
ccc3288
Compare
|
@karenzshea thank you for fixing the test case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR is a fast fix for #4919 and an additional adjustment of geometry assembling.
The adjustment of U-turn range filtering works in the original case for a trace
-73.988775,40.733969;-73.987818,40.735293;-73.986216,40.734619, but fails for the feature test case./cc @karenzshea @TheMarex
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?