Allow excluding ferries on bicycle profile #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMarex
force-pushed
the
bike/no_ferries
branch
from
1286df7
to
a1f36e6
Compare
chaupow
approved these changes
Apr 26, 2018
|
|
||
| When I route I should get | ||
| | from | to | route | turns | classes | | ||
| | a | d | road,road | depart,arrive | [(),(tunnel),()],[()] | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| When I route I should get | ||
| | from | to | route | turns | classes | | ||
| | a | h | ab,df,df,fh,fh | depart,roundabout-exit-2,exit roundabout slight right,notification straight,arrive | [()],[(),()],[(ferry)],[()],[()] | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
TheMarex
force-pushed
the
bike/no_ferries
branch
from
a1f36e6
to
f3f8887
Compare
|
I checked how much memory increases if you add ferry exclusion:
|
|
Ran the same measurements on MLD datasets
|
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Jun 10, 2018
Release OSRM 5.18.0 Changes from 5.17.0: - Features: - ADDED: `table` plugin now optionally returns `distance` matrix as part of response [Project-OSRM#4990](Project-OSRM#4990) - ADDED: New optional parameter `annotations` for `table` that accepts `distance`, `duration`, or both `distance,duration` as values [Project-OSRM#4990](Project-OSRM#4990) - Infrastructure: - ADDED: Updated libosmium and added protozero and vtzero libraries [Project-OSRM#5037](Project-OSRM#5037) - CHANGED: Use vtzero library in tile plugin [Project-OSRM#4686](Project-OSRM#4686) - Profile: - ADDED: Bicycle profile now returns classes for ferry and tunnel routes. [Project-OSRM#5054](Project-OSRM#5054) - ADDED: Bicycle profile allows to exclude ferry routes (default to not enabled) [Project-OSRM#5054](Project-OSRM#5054)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR allows excluding ferries for bicycle routes. This is not enabled by default, just another option for the bicycle profile. A side-effect is that we now also return classes for the bicycle profile which is helpful for navigation.
Tasklist