-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support maxlength and maxweight in car profile #5101
Support maxlength and maxweight in car profile #5101
Conversation
4626ad4
to
e38a465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a question with regard to a refactor you included, otherwise looks good to me!
@@ -25,33 +26,19 @@ function Measure.parse_value_meters(value) | |||
end | |||
end | |||
|
|||
--- according to http://wiki.openstreetmap.org/wiki/Map_Features/Units#Explicit_specifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you say more about why you removed the patterns in favor of the hard coded version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's about implementing a more fail safe version and only extract partial value from the tag.
Thank |
- Changes from 5.18.0: - Optimizations: - CHANGED: Use Grisu2 for serializing floating point numbers. [Project-OSRM#5188](Project-OSRM#5188) - ADDED: Node bindings can return pre-rendered JSON buffer. [Project-OSRM#5189](Project-OSRM#5189) - Profiles: - CHANGED: Bicycle profile now blacklists barriers instead of whitelisting them [Project-OSRM#5076 ](Project-OSRM#5076) - CHANGED: Foot profile now blacklists barriers instead of whitelisting them [Project-OSRM#5077 ](Project-OSRM#5077) - CHANGED: Support maxlength and maxweight in car profile [Project-OSRM#5101](Project-OSRM#5101] - Bugfixes: - FIXED: collapsing of ExitRoundabout instructions [Project-OSRM#5114](Project-OSRM#5114) - Misc: - CHANGED: Support up to 512 named shared memory regions [Project-OSRM#5185](Project-OSRM#5185)
Support in car profile:
like maxheight and maxwidth.