Add optional LTS build - runs after all others, not required to pass. #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
…ive us a heads up when new Node versions break bindings, and might automagically get us support for new versions if it "just works".
danpat
force-pushed
the
danpat_optional_lts_build
branch
from
e8d7034 to
eaf8b89
Compare
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Nov 19, 2020
- Changes from 5.21.0
- Build:
- ADDED: optionally build Node `lts` and `latest` bindings [Project-OSRM#5347](Project-OSRM#5347)
- Features:
- ADDED: new waypoints parameter to the `route` plugin, enabling silent waypoints [Project-OSRM#5345](Project-OSRM#5345)
- ADDED: data timestamp information in the response (saved in new file `.osrm.timestamp`). [Project-OSRM#5115](Project-OSRM#5115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Adds an optional build against Node LTS (whatever version that is at the time). Will run after all other builds, and is not required for a build to pass.
Gives us an opportunity to canary upcoming LTS releases without needing to make sure they pass.
Note: this breaks the build into stages. It's possible that Node 10 and LTS are the same thing, so we don't want the LTS build to cause the Node 10 build to fail by publishing binaries first (
node-pre-gypwill error if binaries are already uploaded).Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?