Increase PackedOSMIDs size to 34 bits #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpat
approved these changes
Apr 24, 2021
OSM node 2^33 was created in early April 2021. This and all subsequently created IDs will be overflowing OSRM node storage which only support 33 bit IDs. Bump the number of bits to 34 to double node ID capacity. This is a breaking change to the data format as it alters the layout of .osrm.nbg_nodes.
mjjbell
force-pushed
the
mbell/packed_34_bit
branch
from
2a0d6f5
to
7f7f8c9
Compare
|
I also met the problem several days ago, and I changed the bit parameter in my branch. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
OSM node 2^33 was created in early April 2021. This and all subsequently created IDs will be overflowing OSRM node storage which only supports 33 bit IDs.
Bump the number of bits to 34 to double node ID capacity. This is a breaking change to the data format as it alters the layout of
.osrm.nbg_nodes.Impact
Increases size of file
.osrm.nbg_nodesand its in-memory representation by ~1%E.g.
germany-latest.osrm.nbg_nodesincreases from 379,732,480 to 383,647,232 bytes.Tasklist
Requirements / Relations
Fixes #6016