Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicycle surface speeds #6212

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Bicycle surface speeds #6212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a504352
Update bicycle.lua
MeijiRestored Feb 27, 2022
4df250b
Update bicycle.lua
MeijiRestored Feb 27, 2022
96e2bf0
Update surface.feature
MeijiRestored Feb 27, 2022
ea495c8
Update CHANGELOG.md
MeijiRestored Feb 27, 2022
3a67f80
Merge branch 'master' into master
SiarheiFedartsou Sep 23, 2022
8089901
Update surface.feature
SiarheiFedartsou Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@
- ADDED: Support snapping to multiple ways at an input location. [#5953](https://github.com/Project-OSRM/osrm-backend/pull/5953)
- FIXED: Fix snapping target locations to ways used in turn restrictions. [#6339](https://github.com/Project-OSRM/osrm-backend/pull/6339)
- ADDED: Support OSM traffic signal directions. [#6153](https://github.com/Project-OSRM/osrm-backend/pull/6153)
- Profile:
- CHANGED: Bicycle surface speeds [#6212](https://github.com/Project-OSRM/osrm-backend/pull/6212)


# 5.26.0
- Changes from 5.25.0
Expand Down
18 changes: 12 additions & 6 deletions features/bicycle/surface.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,34 @@ Feature: Bike - Surfaces
| highway | surface | bothw |
| cycleway | | 48 s |
| cycleway | asphalt | 47.9 s |
| cycleway | chipseal | 48 s |
| cycleway | concrete | 48 s |
| cycleway | concrete_lanes | 48 s |
| cycleway | cobblestone:flattened | 72 s |
| cycleway | paving_stones | 72 s |
| cycleway | wood | 72 s |
| cycleway | compacted | 72 s |
| cycleway | cobblestone | 120 s |
| cycleway | fine_gravel | 120 s |
| cycleway | fine_gravel | 72 s |
| cycleway | ground | 72 s |
| cycleway | dirt | 90 s |
| cycleway | cobblestone | 102.9 s |
| cycleway | gravel | 120 s |
| cycleway | pebblestone | 120 s |
| cycleway | dirt | 120 s |
| cycleway | dirt | 90 s |
| cycleway | earth | 120 s |
| cycleway | grass | 120 s |
| cycleway | mud | 240 s |
| cycleway | sand | 240 s |
| cycleway | sett | 72 s |
| cycleway | sett | 80 s |

Scenario: Bicycle - Good surfaces on small paths
Then routability should be
| highway | surface | bothw |
| cycleway | | 48 s |
| path | | 59.9 s |
| path | | 55.3 s |
| track | | 60 s |
| track | asphalt | 60 s |
| path | asphalt | 60 s |
| path | asphalt | 55.4 s |

Scenario: Bicycle - Surfaces should not make unknown ways routable
Then routability should be
Expand Down
16 changes: 10 additions & 6 deletions profiles/bicycle.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ function setup()
road = default_speed,
service = default_speed,
track = 12,
path = 12
path = 13
},

pedestrian_speeds = {
Expand Down Expand Up @@ -174,21 +174,25 @@ function setup()

surface_speeds = {
asphalt = default_speed,
chipseal = default_speed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjjbell wdyt? At least adding new surfaces seems to be useful, not sure about changed speeds though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

concrete = default_speed,
concrete_lanes = default_speed,
wood = 10,
["cobblestone:flattened"] = 10,
paving_stones = 10,
compacted = 10,
cobblestone = 6,
cobblestone = 7,
unpaved = 6,
fine_gravel = 6,
fine_gravel = 10,
gravel = 6,
pebblestone = 6,
ground = 6,
dirt = 6,
ground = 10,
dirt = 8,
earth = 6,
grass = 6,
mud = 3,
sand = 3,
sett = 10
sett = 9
},

classes = Sequence {
Expand Down