-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back to using custom HTTP parser instead of Boost.Beast #6407
Conversation
CHANGELOG.md
Outdated
- FIXED: Fix inefficient osrm-routed connection handling [#6113](https://github.com/Project-OSRM/osrm-backend/pull/6113) | ||
- FIXED: Fix HTTP compression precedence [#6113](https://github.com/Project-OSRM/osrm-backend/pull/6113) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's right.
@@ -55,4 +55,4 @@ module.exports = function () { | |||
assert.equal(this.processError.process, binary); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't remove "large request" test which I added recently - it will be useful to avoid regression as was introduced by Boost.Beast migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
} | ||
} | ||
else | ||
RequestParser::RequestStatus result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes are made reverting git commits related to Boost.Beast
and subsequent fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9244a97
to
5f150a0
Compare
Tested it and works as expected |
Thanks @lamaux |
v5.27.1 - Changes from 5.27.0 - Misc: - FIXED: Revert back to using custom HTTP parser instead of Boost.Beast. [Project-OSRM#6407](Project-OSRM#6407) - FIXED: Fix bug with large HTTP requests leading to Bad Request in osrm-routed. [Project-OSRM#6403](Project-OSRM#6403) - Routing: - CHANGED: Add support for surface=metal,grass_paver,woodchips in bicyle profile. [Project-OSRM#6395](Project-OSRM#6395)
Issue
Context: #6400 (comment)
closes #6400
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?