support highway="trunk" for foot and bicycle in some countries #6703
Conversation
tombay
changed the title
tombay
changed the title
docs/profiles.md
Outdated
| @@ -83,6 +83,8 @@ access.lua | Function for finding relevant access tags | |||
| destination.lua | Function for finding relevant destination tags | |||
| maxspeed.lua | Function for determining maximum speed | |||
| guidance.lua | Function for processing guidance attributes | |||
| local_trunks.lua |Function to check trunk roads for access based on country | |||
There was a problem hiding this comment.
| local_trunks.lua |Function to check trunk roads for access based on country | |
| local_trunks.lua | Function to check trunk roads for access based on country |
There was a problem hiding this comment.
Hi frodrigo.
I assume the issue is PR #6708 (which resolves PR #6697). I commented on #6697 on 4 Oct while I was working on my issue. I included my changes in my resolution. The issue #6703 (or #6710) addresses the issue where bicycle (and foot) access is allowed on highway="trunk" in some countries.
If #6708 is added the set of countries is reduced. (docs/profiles.md line 400 in this PR).
If #6708 is to be added to Project-OSRM:master I will move this back to draft and then reopen when it is added.
Ciao
Tom
There was a problem hiding this comment.
@systemed What do you think of this change request and two PR ?
docs/profiles.md
Outdated
| ``` | ||
| 'BEL', 'CHL', 'DEU', 'FIN', 'FRA', 'GRC', 'GBR', 'HRV', 'NLD', 'RUS'. | ||
| ``` | ||
| [if the changes in bicycle.lua are are included this comment can be removed] |
There was a problem hiding this comment.
| [if the changes in bicycle.lua are are included this comment can be removed] | |
| [if the changes in bicycle.lua are included this comment can be removed] |
|
It looks like to me the PR now content unrelated changes. |
tombay
force-pushed
the
tombay-trunk-allowed
branch
from
5baeabc
to
203314b
Compare
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
An issue #6710 has been logged (reopening #6701).
Address the issue of highway=trunk (and trunk_link) being blocked for foot and bicycle profiles. Discussed in https://wiki.openstreetmap.org/wiki/Key:motorroad and https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access_restrictions (esp #Alternative_ideas) proposed to address issue via
osrm-backend ... --location-dependent-data trunk-allowed.geojson.
The 30 countries allowing trunk access are include in the polyline data.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?