Attributed string formatting #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-attributed-string
branch
from
b688bc3 to
68e93da
Compare
|
9e87268 adds unit tests for token replacement and fixes a couple edge cases that don’t occur in practice. |
1ec5
force-pushed
the
1ec5-attributed-string
branch
2 times, most recently
from
9c752fc to
ee1df8b
Compare
Added a new variant of string(for:legIndex:numberOfLegs:roadClasses:modifyValueByKey:) that deals in attributed strings.
1ec5
force-pushed
the
1ec5-attributed-string
branch
from
ee1df8b to
0a8959e
Compare
frederoni
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new variant of
OSRMInstructionFormatter.string(for:legIndex:numberOfLegs:roadClasses:modifyValueByKey:)that deals in NSAttributedString instead of String. NSAttributedString is the native rich text object model on Apple platforms, the only one that requires no custom parsing code to work with. Some serving suggestions:Depends on #38.
/cc @frederoni @bsudekum