Skip to content

Make enums public #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2017
Merged

Make enums public #9

merged 1 commit into from
Feb 28, 2017

Conversation

bsudekum
Copy link

Rerolling #8

Makes TokenType enum public along with string(for:modifyValueByKey:)

/cc @frederoni @1ec5

1ec5
1ec5 reviewed Feb 28, 2017
View reviewed changes
Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there needs to be documentation about the overall enum, each case, and the newly public method, so that developers know what to do with them.

@bsudekum bsudekum merged commit bdd962b into master Feb 28, 2017
@bsudekum bsudekum deleted the public-enum branch February 28, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsudekum @1ec5