Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for exits. #116

Merged
merged 2 commits into from
Jul 6, 2017
Merged

Add support for exits. #116

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da902d9
Add support for exits.
willwhite Jul 5, 2017
38c6630
Specify 'on the right'.
willwhite Jul 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions languages/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@
"name": "Take the ramp on the right onto {way_name}",
"destination": "Take the ramp on the right towards {destination}",
"exit": "Take exit {exit}",
"exit_destination": "Take exit {exit} towards {destination}"
"exit_destination": "Take exit {exit} on the right towards {destination}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willwhite, if we’re saying “on the right” in the presence of a destination, why not also say “on the right” in the absence of a destination?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to remove the direction from instructions, except when we have no way/destination/exit at all: Take the ramp on the right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fixed" this by removing the left/right indication in #124.

},
"sharp left": {
"default": "Take the ramp on the left",
Expand All @@ -268,7 +268,7 @@
"name": "Take the ramp on the right onto {way_name}",
"destination": "Take the ramp on the right towards {destination}",
"exit": "Take exit {exit}",
"exit_destination": "Take exit {exit} towards {destination}"
"exit_destination": "Take exit {exit} on the right towards {destination}"
},
"slight left": {
"default": "Take the ramp on the left",
Expand All @@ -282,7 +282,7 @@
"name": "Take the ramp on the right onto {way_name}",
"destination": "Take the ramp on the right towards {destination}",
"exit": "Take exit {exit}",
"exit_destination": "Take exit {exit} towards {destination}"
"exit_destination": "Take exit {exit} on the right towards {destination}"
}
},
"on ramp": {
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/v5/off_ramp/right_exit_destination.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"instructions": {
"de": "Rampe auf der rechten Seite nehmen Richtung Destination 1",
"en": "Take exit 4A towards Destination 1",
"en": "Take exit 4A on the right towards Destination 1",
"es": "Ve cuesta abajo en la derecha hacia Destination 1",
"fr": "Prendre la sortie à droite en direction de Destination 1",
"id": "Ambil jalan melandai di sebelah kanan menuju Destination 1",
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/v5/off_ramp/sharp_right_exit_destination.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"instructions": {
"de": "Rampe auf der rechten Seite nehmen Richtung Destination 1",
"en": "Take exit 4A towards Destination 1",
"en": "Take exit 4A on the right towards Destination 1",
"es": "Ve cuesta abajo en la derecha hacia Destination 1",
"fr": "Prendre la sortie à droite en direction de Destination 1",
"id": "Ambil jalan melandai di sebelah kanan menuju Destination 1",
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/v5/off_ramp/slight_right_exit_destination.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"instructions": {
"de": "Rampe auf der rechten Seite nehmen Richtung Destination 1",
"en": "Take exit 4A towards Destination 1",
"en": "Take exit 4A on the right towards Destination 1",
"es": "Ve cuesta abajo en la derecha hacia Destination 1",
"fr": "Prendre la sortie à droite en direction de Destination 1",
"id": "Ambil jalan melandai di sebelah kanan menuju Destination 1",
Expand Down