Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Finnish translations #239

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Add Finnish translations #239

merged 2 commits into from
Apr 26, 2018

Conversation

akikoskinen
Copy link

Proposing Finnish translations. I continued the translations mentioned in issue #223.

This commit has issues, not all the translations are very fluent. Consider this version for review, but there's definitely room for improvement. I also post this here so that it gets visibility and perhaps some people can help in improving this.

This is the best I can do with just Transifex, but some of these aren't very good Finnish. For example the modifier left is translated as vasemmall(e/a). That's because the modifier is used in different contexts and a different form of the word would be needed. Roughly: "to the left" is "vasemmalle", "on the left" is "vasemmalla".

This and other issues can maybe be solved with the grammar system, but I haven't yet studied how that works.

@yuryleb
Copy link
Contributor

yuryleb commented Apr 21, 2018

Currently grammar works with way_name and rotary_name values only but why not to extend it somehow to process whole phrase or a new keyword? Anyway this could be done in a new pull request but this one should be finished with ChangeLog update 😉

Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions!

This is the best I can do with just Transifex, but some of these aren't very good Finnish. For example the modifier left is translated as vasemmall(e/a). That's because the modifier is used in different contexts and a different form of the word would be needed. Roughly: "to the left" is "vasemmalle", "on the left" is "vasemmalla".

Yes, this is the case for several languages included in this library. I’ve opened #240 to track making more of these cases explicit in the English translation file so that languages like Finnish can translate them on an individual basis. Do you think this is a severe issue that should block merging your PR, or can we massage the left/right translations once #240 is fixed?

@akikoskinen
Copy link
Author

I would say either way is good. The current Finnish in this PR isn't fluent at all places but it's understandable. So I guess it's better than nothing.

Maybe it boils down to the quality ambitions of this project and the release schedule. If the quality ambition is very high and a release is approaching, then I wouldn't include this PR yet. If the approach is more that any value added is good (and can be improved later) or no release is right behind the corner, then I would say that this can go now as it is and once #240 is in, then Finnish (and other) strings can be improved.

So I think I'm throwing the ball right back at ya 😄

Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, in that case, let’s merge this now in anticipation of future improvements. 👍 Thanks again for your help with the translations!

@1ec5 1ec5 merged commit b68af7b into Project-OSRM:master Apr 26, 2018
@akikoskinen akikoskinen deleted the finnish branch April 26, 2018 10:28
1ec5 added a commit that referenced this pull request Jul 19, 2018
- Updated French localization with articles and prepositions insertion using grammar rules. #252
- Added a Burmese localization. #247
- Added a Finnish localization. #239
- Added a Korean localization. #243
- Updated translations in Simplified Chinese. #233 #248
- Updated Russian grammar with 'chord' status street name. #245
- Added Russian church names abbreviations. #237
- Corrected Lithuanian streets abbreviations. #238
1ec5 added a commit that referenced this pull request Jul 19, 2018
- Updated French localization with articles and prepositions insertion using grammar rules. #252
- Added a Burmese localization. #247
- Added a Finnish localization. #239
- Added a Korean localization. #243
- Updated translations in Simplified Chinese. #233 #248
- Updated Russian grammar with 'chord' status street name. #245
- Added Russian church names abbreviations. #237
- Corrected Lithuanian streets abbreviations. #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants