Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, translations; add Catalan #312

Merged
merged 26 commits into from
Mar 3, 2024
Merged

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Mar 3, 2024

Replaced manual HTTP calls to the defunct Transifex API v2 with the Transifex API v3 JavaScript SDK. This required increasing the minimum Node version from 8 to 16 and rewriting the transifex.js script to use async/await and promises.

Added a complete Catalan localization from Transifex. Reran npm run transifex to synchronize this repository with Transifex for the first time since December 2019. I kept various pre-translations where an English string would otherwise have been backfilled. Thanks to the following translators for their help over the past four years or so, and apologies for the delay in pulling in the changes:

Fixes #310 and fixes #311. Supersedes #292, #297, #306, and #307.

@1ec5 1ec5 added translations dependencies Pull requests that update a dependency file labels Mar 3, 2024
@1ec5 1ec5 self-assigned this Mar 3, 2024
This was referenced Mar 3, 2024
@1ec5 1ec5 mentioned this pull request Mar 3, 2024
@1ec5 1ec5 requested review from akashihi, danpaz and freenerd March 3, 2024 09:12
Copy link
Member

@freenerd freenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 ❤️❤️❤️ lgtm

Are you going to release v0.15.0?

//
// auth is stored in ./transifex.auth as json object
// {
// "user": "username",
// "pass": "password"
// "token": "1/0b4e75552e481aeae813aebad53f3de3fcc67ccd"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this token is a fake one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s the one Transifex hard-coded into their documentation. It isn’t mine, in any event. 😅

@1ec5
Copy link
Member Author

1ec5 commented Mar 3, 2024

Are you going to release v0.15.0?

Sure, if I can still figure out how to work this thing.

@1ec5 1ec5 merged commit bcfa11b into master Mar 3, 2024
@1ec5 1ec5 deleted the 1ec5-node-16-tx-3 branch March 3, 2024 22:17
@1ec5
Copy link
Member Author

1ec5 commented Mar 3, 2024

Tracking the release in #313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Transifex API v3 Create Catalan translation
2 participants