Render full image in card without cropping #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the rendered polaroid to show the full image instead of cropping.
As a result, the image and polaroid are a bit more rectangular than square now, which could be seen as a downside (if we dont want to go this route, let me know and we can abandon this PR).
Thought behind change. As a user, if I take a picture and see that the camera is using the full width of my screen, I would expect when I open the photo that I see everything that was within frame when I took the shot. If the photo is cropped, its not clear which parts will be cropped out, which could make it more difficult to take the perfect picture.
Using the same photo here is the before/after
BEFORE:
AFTER
