Camera flash addition #25
Conversation
Camera flash added with on/off option
Clipboard Copy URL fix
client/nui/app.js
Outdated
| function copyToClipboard(text) { | ||
| text = text.replace(/"/g, ''); | ||
| text = text.trim(); | ||
| var textarea = document.createElement('textarea'); | ||
| textarea.value = text; | ||
| textarea.style.position = 'absolute'; | ||
| textarea.style.left = '-9999px'; | ||
| document.body.appendChild(textarea); | ||
| textarea.select(); | ||
| try { | ||
| document.execCommand('copy'); | ||
| } catch (err) { | ||
| console.error('Unable to copy to clipboard:', err); | ||
| } | ||
| document.body.removeChild(textarea); | ||
| } |
There was a problem hiding this comment.
Why make a "copy to clipboard" function? There is a clipboard API built into the browser you have replaced?
There was a problem hiding this comment.
i added this function because clipboard API not work & throws following error
Uncaught (in promise) NotAllowedError: Document is not focused. (@ps-camera/client/nui/index.html:0)
client/cl_main.lua
Outdated
| if doFlash then | ||
| SendNUIMessage({action = "toggleFlash", status = '<b style="color:green;">ON</b>'}) | ||
| else | ||
| SendNUIMessage({action = "toggleFlash", status = '<b style="color:red;">OFF</b>'}) | ||
| end |
There was a problem hiding this comment.
Refactor this code. It has cyber security concerns since people can intercept the status which gets inserted raw into the DOM, making it possible for hacking to inject whatever code they want into the user's UI.
There was a problem hiding this comment.
Definitely, i will rework on this code.
client/nui/app.js
Outdated
| @@ -57,7 +79,10 @@ $(document).ready(function () { | |||
| } else if (event.data.action === 'openPhoto') { | |||
| open(event.data.image, event.data.location); | |||
| } else if (event.data.action === 'SavePic') { | |||
| navigator.clipboard.writeText(str); | |||
| copyToClipboard(event.data.pic); | |||
There was a problem hiding this comment.
Revert line to use Clipboard API.
client/nui/app.js
Outdated
| function toggleflash(status) | ||
| { | ||
| $('#flashstatus').html(status); | ||
| } |
There was a problem hiding this comment.
Refactor this code to alter some already defined markup in the HTML instead of injecting HTML directly. This is very bad practice if you don't know what the user will be sending to you.
README.md
Outdated
|
|
||
| # Preview | ||
| * Camera Overlay | ||
|  | ||
|
|
||
| * Picture Overlay | ||
|  | ||
|
|
||
| * Picture With And Without Flash<br> |
There was a problem hiding this comment.
You should not use HTML tags in a markdown file.
client/cl_main.lua
Outdated
| @@ -139,6 +139,25 @@ function SetLocation() | |||
| end | |||
| end | |||
|
|
|||
| local doFlash = false | |||
| function FlashLightEffect() | |||
There was a problem hiding this comment.
This function can be made local.
Reverted to use Clipboard API but str is undefined so replaced with
Copy existing Photos URL button added
client/nui/app.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| var displayPicture = false; | |||
|
|
|||
| var tempsrc = 'dada'; | |||
There was a problem hiding this comment.
Update variable name and use let instead. Also, remove the value "dada"
Initial value and veriable data type change
|
Requested changes done |
client/nui/app.js
Outdated
| @@ -57,7 +73,9 @@ $(document).ready(function () { | |||
| } else if (event.data.action === 'openPhoto') { | |||
| open(event.data.image, event.data.location); | |||
| } else if (event.data.action === 'SavePic') { | |||
| navigator.clipboard.writeText(str); | |||
| navigator.clipboard.writeText(event.data.pic); | |||
There was a problem hiding this comment.
The event.data.pic is missing to be sanitized for security reasons. Create a method to sanitize it to prevent in-game exploits and cyber attacks on the players PC.
client/nui/app.js
Outdated
|
|
||
| $(document).ready(function() { | ||
| $('#copynow').on('click', function() { | ||
| navigator.clipboard.writeText(tempsrc); |
client/nui/index.html
Outdated
| @@ -76,7 +78,7 @@ | |||
| <div class="status-bar"> | |||
| <div class="battery-life"> | |||
| <i class="fa-solid fa-battery-three-quarters icon"></i> | |||
| <span>69%</span> | |||
| <span>69%</span> <b id="flashstatus" class="off"><i class="fa-solid fa-bolt"></i></b> | |||
There was a problem hiding this comment.
Instead of adding the twice, just add a margin-left to the flashstatus selector in the CSS.
|
Requested changes done |
Added new function, Flash light with on/off option and Fixed Photo URL copy to clipboard after photo capture