Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Loading Strategies #952

Closed
Tracked by #1120
thescientist13 opened this issue Jun 29, 2022 · 0 comments · Fixed by #1157
Closed
Tracked by #1120

Data Loading Strategies #952

thescientist13 opened this issue Jun 29, 2022 · 0 comments · Fixed by #1157
Assignees
Labels
alpha.6 breaking CLI Content as Data feature New feature or request RFC Proposal and changes to workflows, architecture, APIs, etc v0.29.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jun 29, 2022

Type of Change

Feature

Summary

Along with #951 , I would like to review data loading strategies with Greenwood. Also want to revisit the GraphQL plugin now that SSR is in play to see if it makes a difference for prerender configuration, which it depends on.

Details

Take into consideration things like

  • For example, having to Prerender data like when sharing templates for SSR - https://www.greenwoodjs.io/docs/configuration/#prerender
  • Make graph an actual graph (edges + nodes). What's the best data structure for this? Otherwise should we not call it a graph.json?
  • Menus - https://www.greenwoodjs.io/docs/menus/
  • Data Sources - https://www.greenwoodjs.io/docs/data/
  • rename imports field to resources in frontmatter?
  • How to handle data from the client (eg website header + GraphQL - inline ??) vs SSR. Can SSR now just use "real" Apollo client?
  • Deprecate Custom Elements flavor of Include Plugin?
  • data loaders for SSR pages (e.g. getServerSideProps / getStaticProps) for SSR / SSG pages and APIs, export frontmatter
    • Observed in Feature/issue 1008 adapter plugin API #1122 , we don't currently have a way to pass request data into SSR pages, be it through an adapter or not. This would be required to do things like dynamic / slug routing.
    • Should Greenwood or WCC own getData() function?
  • How to vanilla fetch the graph without GraphQL? Come in as compilation props?
  • Can metadata about the build be passed into an SSR page, like the URL, so that you can dynamically render out static menus on a per page basis, a la - Feature/issue 81 contact page AnalogStudiosRI/www.tuesdaystunes.tv#107
  • Change graph.json from path -> url (instance of URL)
  • context plugins as part of SSR
  • refactor context, move all things into manifest.json
@thescientist13 thescientist13 added the RFC Proposal and changes to workflows, architecture, APIs, etc label Jun 29, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Jun 29, 2022
@thescientist13 thescientist13 added the feature New feature or request label Dec 18, 2022
@thescientist13 thescientist13 pinned this issue Apr 9, 2023
@thescientist13 thescientist13 mentioned this issue Jun 29, 2023
25 tasks
@thescientist13 thescientist13 self-assigned this Jul 23, 2023
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 9 - Standards and Conventions Sep 24, 2023
@thescientist13 thescientist13 linked a pull request Oct 7, 2023 that will close this issue
12 tasks
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.6 breaking CLI Content as Data feature New feature or request RFC Proposal and changes to workflows, architecture, APIs, etc v0.29.0
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant