Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #81
Summary of Changes
this.innerHTML
detections so dynamic navigation link underline worksTODO
Notes: would be nice to somehow get the page route being loaded so this would actually work in SSR mode. It's possible with Puppeteer since it s a browser, but would be nice if Greenwood could support this too at build time.
This way, each page could statically stamp out its active status all in HTML, instead of detecting it client side. In the meantime, I wonder if it's worth doing some sort of SSR detection to avoid re-renders upon hydration?