Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 1154 inline template strings in SSR page templates break bundling #1155

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #1154

Summary of Changes

  1. Proper escaping for packing / bundling of template contents in SSR page bundles
  2. Added / updates test cases

@thescientist13 thescientist13 added bug Something isn't working CLI SSR labels Sep 25, 2023
@thescientist13 thescientist13 changed the base branch from master to release/0.29.0 September 25, 2023 12:56
@thescientist13 thescientist13 force-pushed the bug/issue-1154-inline-template-strings-in-ssr-page-templates-break-bundling branch from e8361dc to 9a601a5 Compare October 13, 2023 23:43
@thescientist13 thescientist13 changed the title Bug/issue 1154 inline template strings in ssr page templates break bundling Bug/issue 1154 inline template strings in SSR page templates break bundling Oct 13, 2023
@thescientist13 thescientist13 merged commit f1781e0 into release/0.29.0 Oct 14, 2023
7 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1154-inline-template-strings-in-ssr-page-templates-break-bundling branch October 14, 2023 00:01
thescientist13 added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI SSR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

templates with (inline) template strings breaks bundling of SSR pages
1 participant