-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/issue 1199 gracefully handle unresolvable asset URLs during CSS optimization #1235
Merged
thescientist13
merged 8 commits into
release/0.30.0
from
bug/issue-1199-gracefully-handle-unresolvable-assets
Jun 22, 2024
Merged
bug/issue 1199 gracefully handle unresolvable asset URLs during CSS optimization #1235
thescientist13
merged 8 commits into
release/0.30.0
from
bug/issue-1199-gracefully-handle-unresolvable-assets
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
thescientist13
changed the title
gracefully handle unresolvable assets during CSS optimization
bug/issue 1199 gracefully handle unresolvable URLs during CSS optimization
May 31, 2024
thescientist13
changed the title
bug/issue 1199 gracefully handle unresolvable URLs during CSS optimization
bug/issue 1199 gracefully handle unresolvable asset URLs during CSS optimization
May 31, 2024
thescientist13
force-pushed
the
release/0.30.0
branch
from
June 1, 2024 14:18
c6fb518
to
bb4fdc5
Compare
thescientist13
force-pushed
the
bug/issue-1199-gracefully-handle-unresolvable-assets
branch
from
June 2, 2024 17:25
c104068
to
3933f99
Compare
* initial upgrade for test cases * upgrade CLI and www to Lit v3 * revert static router test case change * all tests passing * patch escodegen for better ESM support * test for lit element hydration script * refactor rollup config * update Lit renderer README and apply conditional Lit script hydration * comments and TODOs cleanup * minor rebase patches * WCC v0.12.0 upgrade and removing patches directory * hydration default documentation and testing for Lit renderer plugin
* intial draft of import attributes support for CSS and JSON * all test cases passing * need patch package * wcc patches for import attributes and CSSStylesheet shim * bump min NodeJS version for exp specs * temp disable ESLint * develop based import assertion specs * serve based import attributes specs * add preIntercept resource plugin lifecycle and refactor PostCSS to use it * all test cases passing for import attributes support * refactor built in CSS and JSON intercepting * demo code * raw plugin docs and package.json updates * update latest documentation for custom loaders support in NodeJS * update custom import docs * upgrade wcc v0.13.0 * only need Node 18 for github actions * css imports and raw plugin interop with test cases * lit renderer import attribute test cases and documentation * refactor matchers support for raw plugin instead of patching and add test cases * disable describe.only * update usage for custom resource plugins to showcase usage of import attributes * document preIntercept lifecycle and convert Babel to use it * restore ESLint * enable debug logging for failing specs * refactor theme pack specs * fix linting * remove CSS and JSON packages from being publishable * clean up console logs and comments * rename exp test cases to loadersnaming prefix * fix command in github actions * remove plugin-import-css callout from plugin-postcss README * remove demo code from website * refine PostCSS plugin intercepting
thescientist13
force-pushed
the
bug/issue-1199-gracefully-handle-unresolvable-assets
branch
from
June 22, 2024 18:07
b67dfe3
to
ed4feb0
Compare
thescientist13
deleted the
bug/issue-1199-gracefully-handle-unresolvable-assets
branch
June 22, 2024 18:21
thescientist13
added a commit
that referenced
this pull request
Nov 2, 2024
…ptimization (#1235) * feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements (#1201) * initial upgrade for test cases * upgrade CLI and www to Lit v3 * revert static router test case change * all tests passing * patch escodegen for better ESM support * test for lit element hydration script * refactor rollup config * update Lit renderer README and apply conditional Lit script hydration * comments and TODOs cleanup * minor rebase patches * WCC v0.12.0 upgrade and removing patches directory * hydration default documentation and testing for Lit renderer plugin * v0.30.0-alpha.1 * feature/issue 923 native import attributes for CSS and JSON (#1215) * intial draft of import attributes support for CSS and JSON * all test cases passing * need patch package * wcc patches for import attributes and CSSStylesheet shim * bump min NodeJS version for exp specs * temp disable ESLint * develop based import assertion specs * serve based import attributes specs * add preIntercept resource plugin lifecycle and refactor PostCSS to use it * all test cases passing for import attributes support * refactor built in CSS and JSON intercepting * demo code * raw plugin docs and package.json updates * update latest documentation for custom loaders support in NodeJS * update custom import docs * upgrade wcc v0.13.0 * only need Node 18 for github actions * css imports and raw plugin interop with test cases * lit renderer import attribute test cases and documentation * refactor matchers support for raw plugin instead of patching and add test cases * disable describe.only * update usage for custom resource plugins to showcase usage of import attributes * document preIntercept lifecycle and convert Babel to use it * restore ESLint * enable debug logging for failing specs * refactor theme pack specs * fix linting * remove CSS and JSON packages from being publishable * clean up console logs and comments * rename exp test cases to loadersnaming prefix * fix command in github actions * remove plugin-import-css callout from plugin-postcss README * remove demo code from website * refine PostCSS plugin intercepting * gracefully handle unresolvable assets during CSS optimization * refactor URL and fs usage * fix lint * missed rebase-a-ronis * missed rebase-a-ronis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
relates to #1199
Observed that in some cases, like when using postcss-import plugin and having all styles inlined, there will be a "loss" of reference point for where to look for files, when these dependencies use relative paths, e.g.
https://unpkg.com/browse/font-awesome@4.6.3/css/font-awesome.css
Which will then cause Greenwood to fail the build
Also, needed is to handle
data:
URLs.https://unpkg.com/browse/bootstrap@4.0.0-alpha.4/dist/css/bootstrap.css
Summary of Changes
url
paths Greenwood can't locate, emit a warningdata:
URLs