Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1355 handle CSS import attributes with PostCSS plugin when prerendering #1361

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 25, 2024

Related Issue

resolves #1355

Documentation

N / A

Summary of Changes

  1. Don't extension check in PostCSS plugin intercepting lifestyle per - https://github.com/ProjectEvergreen/www.greenwoodjs.dev/pull/153/files#diff-745fdda9fef5a58b2eebf6f4a4ccfffa2506fcfb7c2722295528c375bfe71681R432
  2. Have PostCSS plugin forward incoming response.headers

TODO

  1. logo FOUC now? - just needed to refine the implementation
  2. Downstream testing
  3. other instances of extension check in intercepting
  4. (own issue) should the contents / results be inlined or externalized (currently being inlined)? - supported Import Attributes from node modules are not being externalized based on polyfill configuration settings #1365
  5. split off Babel plugin work into its own PR - enhancement/avoid extension checking in Babel resource plugin intercept lifecycle #1366

@thescientist13 thescientist13 force-pushed the bug/issue-1355-postcss-prerender-css-import-attributes-interop branch from 831626f to 80ab655 Compare December 28, 2024 01:15
@thescientist13 thescientist13 merged commit 0bb7392 into master Dec 28, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1355-postcss-prerender-css-import-attributes-interop branch December 28, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Plugins Greenwood Plugins SSR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostCSS plugin breaks bundling of SSR CSS-based import attributes
1 participant