bug/1385 better sanitize Rollup importer for when resolving user workspace resources #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
thescientist13
force-pushed
the
bug/issue-1385-better-sanitize-rollup-importer-when-resolving-workspace-resources
branch
from
1ebc0cf to
2716a7f
Compare
thescientist13
deleted the
bug/issue-1385-better-sanitize-rollup-importer-when-resolving-workspace-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1385
TypeError: Invalid URL at new URL (node:internal/url:775:36) at Object.resolveId (file:///Users/owenbuckley/Workspace/analogstudiosri/api/node_modules/@greenwood/cli/src/config/rollup.config.js:30:27) at file:///Users/owenbuckley/Workspace/analogstudiosri/api/node_modules/rollup/dist/es/shared/node-entry.js:20812:40 at async PluginDriver.hookFirstAndGetPlugin (file:///Users/owenbuckley/Workspace/analogstudiosri/api/node_modules/rollup/dist/es/shared/node-entry.js:20712:28) at async resolveId (file:///Users/owenbuckley/Workspace/analogstudiosri/api/node_modules/rollup/dist/es/shared/node-entry.js:19316:26) at async ModuleLoader.resolveId (file:///Users/owenbuckley/Workspace/analogstudiosri/api/node_modules/rollup/dist/es/shared/node-entry.js:19745:15) at async Object.resolveId (file:///Users/owenbuckley/Workspace/analogstudiosri/api/node_modules/@rollup/plugin-commonjs/dist/es/index.js:580:15) { code: 'PLUGIN_ERROR', input: 'file://\x00stream?commonjs-external', pluginCode: 'ERR_INVALID_URL', plugin: 'commonjs--resolver', hook: 'resolveId' }Documentation
N / A
Summary of Changes
importerwhen handling user workspace resolution (was getting values like\x00stream?commonjs-externalwhich was breakingURL)