-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/issue 426 restore postcss as plugins #473
Merged
thescientist13
merged 14 commits into
release/0.10.0
from
enhancement/issue-426-restore-babel-postcss-as-plugins
Feb 18, 2021
Merged
Enhancement/issue 426 restore postcss as plugins #473
thescientist13
merged 14 commits into
release/0.10.0
from
enhancement/issue-426-restore-babel-postcss-as-plugins
Feb 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…sourceInterfact.intercept signature to include request and response headers
2e285c0
to
13b8084
Compare
5 tasks
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* refactor postcss and import css to standalone plugins and refactor ResourceInterfact.intercept signature to include request and response headers * rollup and css plugin optimization compatibility * move cli postcss test to postcss plugin specs * more refactoring and refining * new rollup plugin API * postcss optimizations working and prism.css working again * got script file output working and comment cleanup * fix postcss config lookup * sort import order * remove commented out code * bundle and link CSS within the CLI and rollup by default * default css optimizations * specs for plugin-import-css * update docs and deleted outdated build docs
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* refactor postcss and import css to standalone plugins and refactor ResourceInterfact.intercept signature to include request and response headers * rollup and css plugin optimization compatibility * move cli postcss test to postcss plugin specs * more refactoring and refining * new rollup plugin API * postcss optimizations working and prism.css working again * got script file output working and comment cleanup * fix postcss config lookup * sort import order * remove commented out code * bundle and link CSS within the CLI and rollup by default * default css optimizations * specs for plugin-import-css * update docs and deleted outdated build docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLI
documentation
Greenwood specific docs
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
P0
Critical issue that should get addressed ASAP
Plugins
Greenwood Plugins
RFC
Proposal and changes to workflows, architecture, APIs, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
part of #426
Summary of Changes
This a bit of doozy so here goes....
import someCss from './some.css';
syntaxResourceInterface.optimization
- not really for "bundling", if you need to get involved with bundling / rollup, create / drop in a a rollup pluginResourceInterface.serve
andResourceInterface.intercept
now get both request and response headersTODOs
@import
rules (as part of Rollupload
lifecycle?)Babel / Browserslist + preset-env(will make as new PR)Move HTML optimizations from- it can waitserlialize
lifecycle to rollup?Thoughts / Topics for Discussion
optimization
features like terser or cssnano, then it might stand to reason we create a newoptimization
configuration called'none'
, so you can choose to disable itterser
andjson
plugins outside of Rollup config, include via rollup pluginexport
s are starting to look really good right now... :)