Make front-matter label var optional #58
Conversation
| const letters = 'abcedfghijklmnopqrstuvwxyz'; | ||
| let short = [], rand = 0; | ||
|
|
||
| for (let n = 0; n < size; n = n + 1) { |
There was a problem hiding this comment.
a forEach or map might be nice here
There was a problem hiding this comment.
But then it has to pick random letters in order. That isn't random. This a popular one from stackoverflow that I've used for multiple projects(albeit usually with multiple cases and numbers).
thescientist13
added
the
enhancement
New Changes
Don't let the number of files deceive you, most are part of the new fixture for seven different tests and 2 files were just being reverted back to their original state. Again, with all these PRs merged, it would be a lot easier to sort out the tests. |
|
A thought, maybe we shouldn't revert the default template markdown. Instead, we should update their tests so that the front-matter var is no longer used by default(without default template markdown pages). |
… page for testing override fm var
|
I set all the mock-app pages to no longer use the front-matter |
| const letters = 'abcedfghijklmnopqrstuvwxyz'; | ||
| let short = [], rand = 0; | ||
|
|
||
| for (let n = 0; n < size; n = n + 1) { |
README.md
Outdated
| # Helloworld | ||
| ``` | ||
| ```` |
There was a problem hiding this comment.
I think it should be only be 3 ticks (`) in markdown?
There was a problem hiding this comment.
yes, I was confused because we used 4 when we had to show a render block within the markdown as an example.
e.g.
```render
<style>${CSS}</style>
<my-component></my-component>
```
| ] | ||
| loader: 'wc-markdown-loader', | ||
| options: { | ||
| graph |
Related Issue
Resolves #30
Summary of Changes
graph:[]within the wc-markdown-loader's advanced optionsBecause of the bug in #54, the root route doesn't appear to be rendering correctly. I suggest you run
yarn install && yarn servethen check http://localhost:8000/hello to see it works and then take a look at source html to see it's using a generated element label with the page-template.This will fail the test because it's looking for
wc-md-hellowhich doesn't exist with generated labels like:wc-md-rjrwbqfor example. This is because I just removed it from the var from template for now, we can add it back once you've tried it out.