Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make resource resolving more graceful and fallback to original ctx.url #599

Merged
merged 2 commits into from
May 15, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 9, 2021

Related Issue

resolves #598

Summary of Changes

  1. Fallback to original ctx.url instead of empty string when resolving

Thoughts

There might be a case to create a new issue or discussion to scope out some more capabilities for the dev server. In light of this issue, I'm wondering what other capabilities users may be expecting / need here that aren't, given the simplicity of the current implementation, for instance

  • make sure cookies and headers are properly forward
  • other methods like PUT, POST, DELETE, etc
  • others?

Made a discussion - #607

@thescientist13 thescientist13 added bug Something isn't working CLI question Further information is requested labels May 9, 2021
@thescientist13 thescientist13 changed the title make user workspace resolving less greedy make resource resolving more graceful and fallback to original ctx.url May 9, 2021
@thescientist13 thescientist13 removed the question Further information is requested label May 15, 2021
@thescientist13 thescientist13 merged commit 5614abd into master May 15, 2021
@thescientist13 thescientist13 deleted the bug/issue-598-preserve-query-params branch May 15, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev server proxy is not forwarding query params
1 participant