Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply type hints to plugin-import-css #616

Merged
merged 3 commits into from
Jun 5, 2021
Merged

apply type hints to plugin-import-css #616

merged 3 commits into from
Jun 5, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 28, 2021 •
edited
Loading

Related Issue

related to #606 (also see #615 )

Summary of Changes

  1. Updated plugin-import-css to support "type" hints for better / explicit for using ESM to load .css files

TODO

  1. Should get rebased after coerce rollup ids with query string to consistent line separators to avoid query strings breaking rollup #621 is merged

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs Plugins Greenwood Plugins labels May 28, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone May 28, 2021
@thescientist13 thescientist13 removed the documentation Greenwood specific docs label May 28, 2021
@thescientist13 thescientist13 mentioned this pull request May 31, 2021
Closed
5 tasks
@thescientist13 thescientist13 self-assigned this May 31, 2021
@thescientist13 thescientist13 merged commit 910450a into master Jun 5, 2021
@thescientist13 thescientist13 deleted the enhancement/discussion-606-add-type-query-support-plugin-import-css branch June 5, 2021 15:31
@thescientist13 thescientist13 removed their assignment Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins v0.13.0
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13