Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 901 lit renderer DSD polyfill #922

Closed
wants to merge 3 commits into from
Closed

Feature/issue 901 lit renderer DSD polyfill #922

wants to merge 3 commits into from

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #901

Will be a breaking change due to needing an additionalGreenwood Resource plugin

Summary of Changes

  1. Add an option for plugin-renderer-lit to support polyfill for making inert <template shadowroot="active"> "active" in browsers that don't support Declarative Shadow DOM
  2. Update README documentation

@thescientist13 thescientist13 added documentation Greenwood specific docs Plugins Greenwood Plugins breaking SSR feature New feature or request labels Mar 27, 2022
@thescientist13 thescientist13 changed the title Feature/issue 901 lit renderer dsd polyfill Feature/issue 901 lit renderer DSD polyfill Mar 27, 2022
thescientist13
thescientist13 commented May 29, 2022
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In retrospect, I think this might be better implemented in our standard polyfills plugin since for an upcoming native Greenwood solution for HTMLElement, which will also need Declarative Shadow DOM, it doesn't really make sense to make it exclusive to particular library.

@thescientist13 thescientist13 marked this pull request as draft June 15, 2022 22:14
@thescientist13 thescientist13 mentioned this pull request Jun 17, 2022
Merged
1 task
@thescientist13
Copy link
Member Author

closing in favor of #944

@thescientist13 thescientist13 deleted the feature/issue-901-lit-renderer-dsd-polyfill branch July 20, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Declarative Shadow DOM polyfill support to polyfill plugin
1 participant
@thescientist13