Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/issue 153 import attributes syntax parsing #157

Merged
merged 8 commits into from
Apr 12, 2024
Merged

feature/issue 153 import attributes syntax parsing #157

merged 8 commits into from
Apr 12, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 10, 2024 •
edited
Loading

Related Issue

resolves #153

Summary of Changes

  1. Add support for parsing import attributes syntax
  2. Bump local project development to Node 18.20.0
  3. Need a custom plugin for ESLint and Import attributes support
  4. Update documentation regarding minimum requirements

TODO

  1. Is an acorn plugin really needed? Surprised its not supported by acorn already... 🤔 - Import Attributes support in Acorn greenwood#1218
  2. Needs a NodeJS version bump? - for local dev, but not for the project
  3. Add a test case

@thescientist13 thescientist13 added feature New feature or request question Further information is requested labels Apr 10, 2024
@thescientist13 thescientist13 self-assigned this Apr 10, 2024
@thescientist13 thescientist13 force-pushed the feature/issue-153-import-attributes-syntax-parsing branch from 436f3c6 to 47e136b Compare April 12, 2024 20:41
@thescientist13 thescientist13 added the documentation Improvements or additions to documentation label Apr 12, 2024
This was referenced Apr 12, 2024
Open
Open
@thescientist13 thescientist13 removed the question Further information is requested label Apr 12, 2024
@thescientist13 thescientist13 merged commit c97da38 into master Apr 12, 2024
12 checks passed
@thescientist13 thescientist13 deleted the feature/issue-153-import-attributes-syntax-parsing branch April 12, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import Attributes syntax parsing
1 participant
@thescientist13