Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 150 create single discord link endpoint and rewrites #151

Merged
merged 10 commits into from
Dec 22, 2024
Merged

enhancement/issue 150 create single discord link endpoint and rewrites #151

merged 10 commits into from
Dec 22, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 15, 2024 •
edited
Loading

Related Issue

resolves #150

Summary of Changes

  1. Create an API endpoint for handling redirect
  2. Use Netlify redirects to map /discord -> /api/discord
  3. Create a redirect in netlify.toml to map /discord -> Discord invite link
  4. Update all links in the website
  5. Document this redirect in the CONTRIBUTING docs

TODO

  1. Location header not coming through on the API endpoint? - https://deploy-preview-151--super-tapioca-5987ce.netlify.app/api/discord
    Screenshot 2024-12-15 at 4 52 00 PM
  2. would be nice to do this with a rewrite though...

@thescientist13 thescientist13 added docs Greenwood specific content like docs and guides enhancement New feature or request content Non Greenwood specific content like home page copy text, blog posts, etc labels Dec 15, 2024
@thescientist13 thescientist13 mentioned this pull request Dec 15, 2024
Merged
1 task
@thescientist13 thescientist13 changed the title create discord link and redirects enhancement/issue 150 create single discord link endpoint and rewrites Dec 15, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 15, 2024 •
edited
Loading

✅ Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 8270b44
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/6767588d989e4000083f58b0
😎 Deploy Preview https://deploy-preview-151--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 changed the title enhancement/issue 150 create single discord link endpoint and rewrites feature/issue 150 create single discord link endpoint and rewrites Dec 22, 2024
@thescientist13 thescientist13 changed the title feature/issue 150 create single discord link endpoint and rewrites enhancement/issue 150 create single discord link endpoint and rewrites Dec 22, 2024
@thescientist13 thescientist13 merged commit 0547162 into main Dec 22, 2024
5 checks passed
@thescientist13 thescientist13 deleted the feature/issue-150-discord-link-and-redirects branch December 22, 2024 00:11
@thescientist13 thescientist13 added the documentation website project / repo specific documentation label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content Non Greenwood specific content like home page copy text, blog posts, etc docs Greenwood specific content like docs and guides documentation website project / repo specific documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dedicated Discord link endpoint and rewriting
1 participant
@thescientist13