Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/clarify SSR body and layout APIs #160

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 22, 2025

Related Issue

Got some feedback in Discord that some of the docs around SSR pages and layouts wasn't clear in certain areas. For example, in the case of SSR pages, it was not clear the relationship between default export and getBody APIs, which used to be a bit clearer on the old website
Screenshot 2025-01-21 at 7 48 12 PM

Summary of Changes

  1. Clarify relationship between default export and getBody SSR page APIs
  2. Realized there wasn't an example of a basic dynamic layout

TODO

  1. Confirm support of custom resources for layouts (e.g. TypeScript, src/pages/app.ts) like we do for SSR pages and API routes - https://github.com/ProjectEvergreen/greenwood/tree/master/packages/plugin-typescript#pages - support custom resource plugin formats for layouts greenwood#1395
  2. confirm / clarify expectations around frontmatter layouts mapping - dynamic runtime layouts for SSR greenwood#1248 (comment)

@thescientist13 thescientist13 added the docs Greenwood specific content like docs and guides label Jan 22, 2025
@thescientist13 thescientist13 self-assigned this Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 1dac3e8
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/67925a88c614f00008302f00
😎 Deploy Preview https://deploy-preview-160--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 force-pushed the docs/clarify-ssr-apis-and-layouts branch from ae5891f to 1dac3e8 Compare January 23, 2025 15:04
@thescientist13 thescientist13 merged commit 8c3dc1a into main Jan 23, 2025
5 checks passed
@thescientist13 thescientist13 deleted the docs/clarify-ssr-apis-and-layouts branch January 23, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific content like docs and guides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant