Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/issue 27 footer component #60

Merged
merged 4 commits into from
Jun 24, 2024
Merged

feature/issue 27 footer component #60

merged 4 commits into from
Jun 24, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 17, 2024 •
edited
Loading

Related Issue

resolves #27

Summary of Changes

  1. Created Footer component and update test cases

TODO

  1. Need to invert the colors for the text and social icons, they should be white (not green / black respectively)
    Screenshot 2024-06-17 at 12 22 42 PM
  2. Assuming there's an easy to way accomplish the above and easily invert colors with a shared SVG, should track an issue to make a shared "social icons tray" component - Social Icons Tray component #63

@thescientist13 thescientist13 added enhancement New feature or request help wanted Extra attention is needed labels Jun 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit cafdb3c
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/6679ab34493d5400087a69d5
😎 Deploy Preview https://deploy-preview-60--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 mentioned this pull request Jun 17, 2024
Closed
@thescientist13 thescientist13 mentioned this pull request Jun 24, 2024
Open
@thescientist13 thescientist13 force-pushed the feature/issue-27-footer-component branch from 64c6048 to cafdb3c Compare June 24, 2024 17:21
@thescientist13 thescientist13 removed the help wanted Extra attention is needed label Jun 24, 2024
thescientist13
thescientist13 commented Jun 24, 2024
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aholtzman , fill worked! 🙌

@thescientist13 thescientist13 merged commit b631ad2 into main Jun 24, 2024
5 checks passed
@thescientist13 thescientist13 deleted the feature/issue-27-footer-component branch June 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer Component
1 participant
@thescientist13