Pluralize item counts for English, at least; fixes #3268 (#3446)

ProjectMirador · Jun 15, 2021 · eefc88a · eefc88a
1 parent d215c3d
commit eefc88a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/components/ManifestListItem.js b/src/components/ManifestListItem.js
@@ -135,7 +135,7 @@ export class ManifestListItem extends React.Component {
             </Grid>
             <Grid item xs={8} sm={4}>
               <Typography className={ns('manifest-list-item-provider')}>{provider || t('addedFromUrl')}</Typography>
-              <Typography>{t('numItems', { number: size })}</Typography>
+              <Typography>{t('numItems', { count: size, number: size })}</Typography>
             </Grid>
 
             <Grid item xs={4} sm={2}>

diff --git a/src/components/WindowSideBarAnnotationsPanel.js b/src/components/WindowSideBarAnnotationsPanel.js
@@ -26,7 +26,7 @@ export class WindowSideBarAnnotationsPanel extends Component {
         titleControls={<AnnotationSettings windowId={windowId} />}
       >
         <div className={classes.section}>
-          <Typography component="p" variant="subtitle2">{t('showingNumAnnotations', { number: annotationCount })}</Typography>
+          <Typography component="p" variant="subtitle2">{t('showingNumAnnotations', { count: annotationCount, number: annotationCount })}</Typography>
         </div>
 
         {canvasIds.map((canvasId, index) => (

diff --git a/src/locales/en/translation.json b/src/locales/en/translation.json
@@ -93,7 +93,8 @@
     "moveCompanionWindowToRight": "Move to right",
     "nextCanvas": "Next item",
     "noItemSelected": "No item selected",
-    "numItems": "{{number}} items",
+    "numItems": "{{number}} item",
+    "numItems_plural": "{{number}} items",
     "off": "Off",
     "openCompanionWindow_annotations": "Annotations",
     "openCompanionWindow_attribution": "Rights",
@@ -121,7 +122,8 @@
     "searchSubmitAria": "Submit search",
     "searchTitle": "Search",
     "selectWorkspaceMenu": "Select workspace type",
-    "showingNumAnnotations": "Showing {{number}} annotations",
+    "showingNumAnnotations": "Showing {{number}} annotation",
+    "showingNumAnnotations_plural": "Showing {{number}} annotations",
     "showCollection": "Show collection",
     "showZoomControls": "Show zoom controls",
     "sidebarPanelsNavigation": "Sidebar panels navigation",
@@ -134,8 +136,10 @@
     "thumbnailNavigation": "Thumbnails",
     "thumbnails": "Thumbnails",
     "toggleWindowSideBar": "Toggle sidebar",
-    "totalCollections": "{{count}} collections",
-    "totalManifests": "{{count}} manifests",
+    "totalCollections": "{{count}} collection",
+    "totalCollections_plural": "{{count}} collections",
+    "totalManifests": "{{count}} manifest",
+    "totalManifests_plural": "{{count}} manifests",
     "tryAgain": "Try again",
     "untitled": "[Untitled]",
     "view": "View",