789 slider styling improvements #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # js/src/settings.js # js/src/widgets/contextControls.js # js/src/widgets/imageView.js
…ange css filter property and rotate uses OSD functionality
… added tooltips for annotation controls. pass canvas controls from window to other modules. need to fix css for image manipulation controls when the annotation controls are turned off
# Conflicts: # js/src/widgets/contextControls.js
|
Hm. I need to write some tests for this. |
|
Yes, we need to write tests, but we changed different widgets, which will get significantly modified by iiifManifestLayouts, which is why we haven't added tests yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styles sliders on image manipulation controls so they appear underneath the caret of their respective icons. Displays the percentage represented by the slider to the right of the handle. Updates on reset.