Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPIKE: Drag and drop #3094

Merged
merged 6 commits into from
Jun 18, 2020
Merged

SPIKE: Drag and drop #3094

merged 6 commits into from
Jun 18, 2020

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Jun 8, 2020 •
edited
Loading

Fixes #2356
Fixes #2629
Fixes #2903

  • adding new manifests to the WorkspaceAdd by dropping a manifest
  • adding new manifests to the WorkspaceAdd by dropping a drag+drop link
  • adding new windows by dropping a manifest onto the workspace
  • adding new windows by dropping a drop+drop link onto the workspace
  • adding new windows by dropping the image(s) onto the workspace
  • adding new manifests to the catalog by dropping the image(s) onto the workspace

TODO:

  • fix something up in react-mosaic-component so it reuses the DnDContext from mirador instead of wanting its own
  • add some tests for windows coming in with manifests
  • add tests for dropping on workspaceadd and workspace
  • add tests for IIIFDropTarget
  • figure out any design affordances

@cbeer cbeer mentioned this pull request Jun 8, 2020
Merged
@cbeer cbeer force-pushed the dnd2 branch 3 times, most recently from e9f801e to 90320ae Compare June 16, 2020 22:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1aa37a1). Click here to learn what that means.
The diff coverage is n/a.

@cbeer cbeer force-pushed the dnd2 branch 3 times, most recently from b9eaa83 to 184d5a6 Compare June 17, 2020 16:27
@cbeer cbeer marked this pull request as ready for review June 17, 2020 18:41
cbeer
cbeer commented Jun 17, 2020
View reviewed changes
webpack.config.js
resolve: {
alias: {
// needs shared global state for context to work
'react-dnd': path.resolve(path.join(__dirname, 'node_modules', 'react-dnd')),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how acceptable this is, but it seems like it works well enough for now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it will be fine for this UMD build. However I think adopters who build their own package may need to do something similar

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And they'd probably want to anyway, for exactly the same reasons

@mejackreed mejackreed merged commit a48da67 into master Jun 18, 2020
@mejackreed mejackreed deleted the dnd2 branch June 18, 2020 22:41
@cbeer cbeer mentioned this pull request Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejackreed mejackreed mejackreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cbeer @codecov-commenter @mejackreed