Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - tidying eligibility filters #1206

Merged
merged 4 commits into from
May 2, 2023
Merged

Conversation

DJViau
Copy link
Contributor

@DJViau DJViau commented May 2, 2023

This is just almost entirely cleanup.

  • It just shuffles around the functions so that all the helpers are at the top and the filters follow.
  • It also cleans up one naming convention violation I perpetrated a while back.
  • It adds some quick and dirty comments.

One logic change:

  • It removes superfluous ineligibility criteria on one filter (we were treating match* functions as ineligible when it seems they were eligible). I fuzzed for an hour and a half or so and didn't hit any issues, but I'm not sure how frequently the mutation gets hit and whether an hour and a half of fuzzing is even enough for confidence in the relatively frequently hit mutations these days.

IMO this is mergable now if we want it in ASAP (to avoid merge conflicts) but I'm planning on coming back to it and working more on this branch once I get the docs updates done.

EDIT: This now also includes a bunch of comments on the whats and whys of some mutations. Still a WIP but imo still could be merged at any point.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4d7bfc5) 100.00% compared to head (c24a7d7) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         2652      2652           
  Branches       396       396           
=========================================
  Hits          2652      2652           
Flag Coverage Δ
foundry 77.80% <ø> (ø)
production 100.00% <ø> (ø)
reference 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0age 0age merged commit 0705852 into main May 2, 2023
@0age 0age deleted the dan/2023/05/tidying-eligibility-filters branch May 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants