WIP - tidying eligibility filters #1206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just almost entirely cleanup.
One logic change:
IMO this is mergable now if we want it in ASAP (to avoid merge conflicts) but I'm planning on coming back to it and working more on this branch once I get the docs updates done.
EDIT: This now also includes a bunch of comments on the whats and whys of some mutations. Still a WIP but imo still could be merged at any point.