Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to fuzz engine #1230

Merged
merged 7 commits into from
May 9, 2023
Merged

Add validation to fuzz engine #1230

merged 7 commits into from
May 9, 2023

Conversation

horsefacts
Copy link
Contributor

@horsefacts horsefacts commented May 9, 2023

Add validate step to FuzzEngine and store validation results in context. This does not make any assertions about the resulting errors, but does exercise the SeaportValidator with many unusual orders, and adds validation results to fuzz_debug.json, which is helpful for debugging.

  • Wire up SeaportValidator to FuzzEngine
  • Validate orders before execSuccess and add returned ErrorsAndWarnings (per order) to test context.
  • Add a uint16[].toIssueString() helper to format an array of validator error codes as a list in test output.
  • Serialize validator errors in fuzz_debug.json:
Screenshot 2023-05-09 at 4 13 36 PM

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (68e33e4) 99.96% compared to head (2ba98f5) 99.96%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1230   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          47       47           
  Lines        2653     2653           
  Branches      396      396           
=======================================
  Hits         2652     2652           
  Misses          1        1           
Flag Coverage Δ
foundry 77.85% <ø> (ø)
production 99.91% <ø> (ø)
reference 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@horsefacts horsefacts marked this pull request as ready for review May 9, 2023 21:03
@0age 0age merged commit aead605 into main May 9, 2023
@0age 0age deleted the horsefacts/fuzz-seaport-validator branch May 9, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants