Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for failing validation of signed order after counter is incremented #883

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

DJViau
Copy link
Contributor

@DJViau DJViau commented Jan 17, 2023

Per request of @jameswenzel

@DJViau DJViau requested a review from emo-eth January 17, 2023 14:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Base: 85.68% // Head: 85.68% // No change to project coverage 👍

Coverage data is based on head (995896b) compared to base (11c74c9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.2     #883   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          52       52           
  Lines        3101     3101           
  Branches      413      413           
=======================================
  Hits         2657     2657           
  Misses        443      443           
  Partials        1        1           
Flag Coverage Δ
foundry 63.12% <ø> (ø)
production 99.76% <ø> (ø)
reference 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DJViau DJViau merged commit f1cc7b8 into 1.2 Jan 17, 2023
@DJViau DJViau deleted the dan/2023/01/test-validate-fails-after-counter-increment branch January 17, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants