Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SeaportRouter #966

Merged
merged 13 commits into from
Feb 8, 2023
Merged

Add SeaportRouter #966

merged 13 commits into from
Feb 8, 2023

Commits on Feb 5, 2023

  1. add SeaportRouter and tests

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    11ab710 View commit details
    Browse the repository at this point in the history

  2. - only set reentrancy on main fn 

    - send funds back once at the end of the fn instead of on every receive
- optimize checking seaport address
    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    8a641c5 View commit details
    Browse the repository at this point in the history

  3. test that seaport address can send ether to router contract

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    418a6a1 View commit details
    Browse the repository at this point in the history

  4. remove fallback

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    9d87b2d View commit details
    Browse the repository at this point in the history

  5. fix lint warnings

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2592433 View commit details
    Browse the repository at this point in the history

  6. optimization: use newAvailableOrders in place of availableOrders[i]

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    7f5e6a2 View commit details
    Browse the repository at this point in the history

  7. consolidate files into interface

    @ryanio
    ryanio committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    fbf805a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. avoid stack too deep errors

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    206fd35 View commit details
    Browse the repository at this point in the history

  2. remove unused constant

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    20eefeb View commit details
    Browse the repository at this point in the history

  3. skip router in ref tests

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4ae2e23 View commit details
    Browse the repository at this point in the history

  4. define empty memory vars instead of allocating arrays

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    a3161e9 View commit details
    Browse the repository at this point in the history

  5. add disclaimer that router only works for native consideration items

    @ryanio
    ryanio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0aadb03 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. shorten comment to satisfy line length lint

    @ryanio
    ryanio committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    c873f2a View commit details
    Browse the repository at this point in the history