Seaport 1.3 #990
Draft
Seaport 1.3 #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seaport 1.2 Release
deployed 1.2 across all chains
…index-overflow-test-and-refactor add a test for index overflow with trees of different heights and refactor a bit
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
- send funds back once at the end of the fn instead of on every receive - optimize checking seaport address
Add SeaportRouter
…ttp-cache-semantics-4.1.1 Bump http-cache-semantics from 4.1.0 to 4.1.1
loop through orders again if restricted/contract present
…dator Transfer Validation Zone/Offerer
refactor typehash lookup as while loop
…ost-execution TestTransferValidationZoneOfferer fulfillAvailable tests with conduit + Add sol helpers
Stephan/1.3 forge tests
1.3 final cleanup
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## seaport-1.2 #990 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 47 46 -1
Lines 2661 2741 +80
Branches 393 409 +16
=============================================
+ Hits 2661 2741 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…n-leave Difference is pretty negligible in terms of gas/code, but it is a bit easier to follow
Improve typehash lookup readability
Refactor bulk order typehash lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR highlights changes from Seaport 1.2 to Seaport 1.3 and is meant to facilitate review and discussion of those changes.