Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin jupyter_server to < 2 #101

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

brian-rose
Copy link
Member

Trying to address #100 following @jnmorley's suggestion: here we pin jupyter_server<2 to see if that gets rid of the version conflict for jsonschema

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 01dd52c
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-template/_preview/101

@brian-rose brian-rose changed the title pin juptyer_server to < 2 pin jupyter_server to < 2 Jan 3, 2023
@brian-rose
Copy link
Member Author

This does seem to resolve the build problem!

@brian-rose brian-rose marked this pull request as ready for review January 3, 2023 13:50
@brian-rose brian-rose merged commit a8496a7 into ProjectPythia:main Jan 3, 2023
@brian-rose brian-rose deleted the jsonfail branch January 3, 2023 16:56
github-actions bot pushed a commit that referenced this pull request Jan 3, 2023
weiji14 added a commit to weiji14/zen3geo that referenced this pull request Jan 12, 2023
The latest jupyter_server=2.0.6 version installed via readthedocs requires a version of jsonschema which is incompatible with jupyter-book=0.13, resulting in an error like `pkg_resources.UnknownExtra: jsonschema 3.2.0 has no such extra feature 'format-nongpl'`, see also ProjectPythia/cookbook-template#100 (comment) for details. Applying the workaround from ProjectPythia/cookbook-template#101 for now.

Also remove the ipython!=8.7.0 pin added in d29b4bd, since ipython=8.8.0 is released now.
weiji14 added a commit to weiji14/zen3geo that referenced this pull request Jan 12, 2023
* ⬆️ Bump gitpython from 3.1.27 to 3.1.30

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.27 to 3.1.30.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.27...3.1.30)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* 🩹 Relock with poetry 1.3.0

Use new poetry lock file format (version 2.0).

* 📌 Temporarily pin jupyter_server<2 to prevent jsonschema error

The latest jupyter_server=2.0.6 version installed via readthedocs requires a version of jsonschema which is incompatible with jupyter-book=0.13, resulting in an error like `pkg_resources.UnknownExtra: jsonschema 3.2.0 has no such extra feature 'format-nongpl'`, see also ProjectPythia/cookbook-template#100 (comment) for details. Applying the workaround from ProjectPythia/cookbook-template#101 for now.

Also remove the ipython!=8.7.0 pin added in d29b4bd, since ipython=8.8.0 is released now.

* 💚 Use jupyter_server==1.* pinning

Prevent the ` /bin/sh: 1: cannot open 2: No such file` error in readthedocs build due to `<2` not being escaped properly.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant