Skip to content

Conversation

@jukent
Copy link
Contributor

@jukent jukent commented May 14, 2024

This is more in line with how Pythia foundations handles the extra footer information. Instead of #115

Related to ProjectPythia/pythia-foundations#397

@jukent jukent requested review from brian-rose and erogluorhan May 14, 2024 17:57
@github-actions
Copy link

github-actions bot commented May 14, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 2e9d040
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-template/_preview/172

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick suggestions.

jukent and others added 2 commits May 14, 2024 12:37
@jukent jukent requested a review from brian-rose May 14, 2024 18:41
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jukent
Copy link
Contributor Author

jukent commented May 15, 2024

There seems to be a repeated footer before the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants