Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Google Analytics Workaround Once pydata_sphinx_theme Fix Released #128

Closed
erogluorhan opened this issue Sep 1, 2021 · 3 comments · Fixed by #160
Closed

Revert Google Analytics Workaround Once pydata_sphinx_theme Fix Released #128

erogluorhan opened this issue Sep 1, 2021 · 3 comments · Fixed by #160
Labels
infrastructure Infrastructure related issue

Comments

@erogluorhan
Copy link
Member

erogluorhan commented Sep 1, 2021 •
edited
Loading

We now have Google Analytics working for our Foundations Book with the help of PR #123.

Our PR was just a workaround until pydata/pydata-sphinx-theme#439gets merged and released. So, once it is done, our PR #123 should better be reverted.
@erogluorhan erogluorhan added the infrastructure Infrastructure related issue label Sep 1, 2021
@erogluorhan erogluorhan changed the title Revert Google Analytics Workaround Once Pydata Fix Released Revert Google Analytics Workaround Once pydata_sphinx_theme Fix Released Sep 1, 2021
@brian-rose brian-rose mentioned this issue Sep 9, 2021
Closed
@brian-rose
Copy link
Member

Just noting here that pydata/pydata-sphinx-theme#439 was apparently merged recently, so we can circle back to this whenever the next release of pydata-sphinx-theme happens (currently at v0.6.3)

@erogluorhan
Copy link
Member Author

Yes, I am keeping my eyes on their release, too. Thanks for reminding!

@erogluorhan
Copy link
Member Author

Just started to address this as pydata-sphinx-theme released their v0.7.0 with the g-analytics fix.

@erogluorhan erogluorhan mentioned this issue Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Infrastructure related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert PR#123 changes in favor of pydata-sphinx-theme v0.7.0 ProjectPythia/pythia-foundations
2 participants
@brian-rose @erogluorhan